d3d11: only dirty stages that bind a CB on WRITE_DISCARD map#175
Closed
cyyever wants to merge 1 commit into
Closed
d3d11: only dirty stages that bind a CB on WRITE_DISCARD map#175cyyever wants to merge 1 commit into
cyyever wants to merge 1 commit into
Conversation
WRITE_DISCARD of a dynamic buffer/texture used to dirty every shader stage's CB/SRV set, forcing a redundant argument-table re-encode next draw on stages that never bound it. Now only stages that actually bind the resource are dirtied, on both immediate and deferred contexts.
Owner
|
No, nested for loop is totally a no-go. WRITE_DISCARD map should be as cheap as possible (there would be typically a sequence of map before a draw/dispatch). I see redundant stage encoding can be improved but NOT by checking existing bindings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WRITE_DISCARD of a dynamic buffer/texture used to dirty every shader stage's CB/SRV set, forcing a redundant argument-table re-encode next draw on stages that never bound it. Now only stages that actually bind the resource are dirtied, on both immediate and deferred contexts.